Merge pull request 'Fixed websocket' (#29) from Alex/stcs:devel into stable

Reviewed-on: #29

app/bybit/open_positions.py

@@ -54,12 +54,6 @@ async def start_trading_cycle(
             tg_id=tg_id,
             symbol=symbol,
             mode=0)
-        await set_margin_mode(tg_id=tg_id, margin_mode=margin_type)
-        await set_leverage(
-            tg_id=tg_id,
-            symbol=symbol,
-            leverage=leverage,
-        )
 
         await rq.set_user_deal(
             tg_id=tg_id,
@@ -107,7 +101,8 @@ async def start_trading_cycle(
                    "position idx not match position mode",
                    "Qty invalid",
                    "The number of contracts exceeds maximum limit allowed",
-                   "The number of contracts exceeds minimum limit allowed"
+                   "The number of contracts exceeds minimum limit allowed",
+                   "Order placement failed as your position may exceed the max",
                }
             else None
         )
@@ -193,6 +188,7 @@ async def trading_cycle_profit(
                    "ab not enough for new order",
                    "InvalidRequestError",
                    "The number of contracts exceeds maximum limit allowed",
+                   "Order placement failed as your position may exceed the max",
                }
             else None
         )
@@ -293,6 +289,7 @@ async def trading_cycle(
                    "ab not enough for new order",
                    "InvalidRequestError",
                    "The number of contracts exceeds maximum limit allowed",
+                   "Order placement failed as your position may exceed the max",
                }
             else None
         )
@@ -313,7 +310,12 @@ async def open_positions(
     try:
         client = await get_bybit_client(tg_id=tg_id)
         get_ticker = await get_tickers(tg_id, symbol=symbol)
-        price_symbol = safe_float(get_ticker.get("lastPrice")) or 0
+
+        if get_ticker is None:
+            price_symbol = 0
+        else:
+            price_symbol = safe_float(get_ticker.get("lastPrice"))
+
         instruments_info = await get_instruments_info(tg_id=tg_id, symbol=symbol)
         qty_step_str = instruments_info.get("lotSizeFilter").get("qtyStep")
         qty_step = safe_float(qty_step_str)
@@ -363,6 +365,7 @@ async def open_positions(
             "Qty invalid": "Qty invalid",
             "The number of contracts exceeds maximum limit allowed": "The number of contracts exceeds maximum limit allowed",
             "The number of contracts exceeds minimum limit allowed": "The number of contracts exceeds minimum limit allowed",
+            "Order placement failed as your position may exceed the max": "Order placement failed as your position may exceed the max",
         }
         for key, msg in known_errors.items():
             if key in error_text:

app/bybit/set_functions/set_tp_sl.py

@@ -25,11 +25,13 @@ async def set_tp_sl_for_position(
     """
     try:
         client = await get_bybit_client(tg_id)
+        take_profit = round(take_profit_price, 6) if take_profit_price is not None else None
+        stop_loss = round(stop_loss_price, 6) if stop_loss_price is not None else None
         resp = client.set_trading_stop(
             category="linear",
             symbol=symbol,
-            takeProfit=str(round(take_profit_price, 5)),
-            stopLoss=str(round(stop_loss_price, 5)),
+            takeProfit=str(take_profit) if take_profit is not None else None,
+            stopLoss=str(stop_loss) if stop_loss is not None else None,
             positionIdx=position_idx,
             tpslMode="Full",
         )

app/bybit/telegram_message_handler.py

@@ -1,9 +1,10 @@
 import logging.config
 import math
-
+# import json
 import app.telegram.keyboards.inline as kbi
 import database.request as rq
 from app.bybit.get_functions.get_instruments_info import get_instruments_info
+from app.bybit.get_functions.get_positions import get_active_positions_by_symbol
 from app.bybit.logger_bybit.logger_bybit import LOGGING_CONFIG
 from app.bybit.open_positions import trading_cycle, trading_cycle_profit
 from app.bybit.set_functions.set_tp_sl import set_tp_sl_for_position
@@ -56,7 +57,10 @@ class TelegramMessageHandler:
 
     async def format_execution_update(self, message, tg_id):
         try:
+            # logger.info("Execution update: %s", json.dumps(message))
             execution = message.get("data", [{}])[0]
+            exec_type = format_value(execution.get("execType"))
+            if exec_type == "Trade" or exec_type == "BustTrade":
                 closed_size = format_value(execution.get("closedSize"))
                 symbol = format_value(execution.get("symbol"))
                 exec_price = format_value(execution.get("execPrice"))
@@ -64,6 +68,14 @@ class TelegramMessageHandler:
                 exec_fees = format_value(execution.get("execFee"))
                 fee_rate = format_value(execution.get("feeRate"))
                 side = format_value(execution.get("side"))
+
+                user_auto_trading = await rq.get_user_auto_trading(
+                    tg_id=tg_id, symbol=symbol
+                )
+                auto_trading = (
+                    user_auto_trading.auto_trading if user_auto_trading else False
+                )
+
                 side_rus = (
                     "Покупка"
                     if side == "Buy"
@@ -81,11 +93,11 @@ class TelegramMessageHandler:
                         tg_id=tg_id, symbol=symbol, fee=safe_float(exec_fee)
                     )
 
-            user_auto_trading = await rq.get_user_auto_trading(
-                tg_id=tg_id, symbol=symbol
-            )
+                get_total_fee = 0
 
+                if user_auto_trading is not None:
                     get_total_fee = user_auto_trading.total_fee
+
                 total_fee = safe_float(exec_fee) + safe_float(get_total_fee)
 
                 exec_pnl = format_value(execution.get("execPnl"))
@@ -96,15 +108,17 @@ class TelegramMessageHandler:
                     "Сделка закрыта:" if safe_float(closed_size) > 0 else "Сделка открыта:"
                 )
                 text = f"{header}\n" f"Торговая пара: {symbol}\n"
-
-            auto_trading = (
-                user_auto_trading.auto_trading if user_auto_trading else False
-            )
                 user_deals_data = await rq.get_user_deal_by_symbol(
                     tg_id=tg_id, symbol=symbol
                 )
-            commission_fee = user_deals_data.commission_fee
-            commission_place = user_deals_data.commission_place
+                if user_deals_data is None:
+                    commission_fee = "Yes_commission_fee"
+                    commission_place = "Commission_for_qty"
+
+                else:
+                    commission_fee = user_deals_data.commission_fee or "Yes_commission_fee"
+                    commission_place = user_deals_data.commission_place or "Commission_for_qty"
+
                 current_series = user_deals_data.current_series
                 current_step = user_deals_data.current_step
                 order_quantity = user_deals_data.order_quantity
@@ -175,26 +189,49 @@ class TelegramMessageHandler:
                         take_profit_price = max(take_profit_price, 0)
                         stop_loss_price = max(stop_loss_price, 0)
 
-                await set_tp_sl_for_position(tg_id=tg_id,
+                    ress = await set_tp_sl_for_position(tg_id=tg_id,
                                                         symbol=symbol,
                                                         take_profit_price=take_profit_price,
                                                         stop_loss_price=stop_loss_price,
                                                         position_idx=0)
-
-                take_profit_truncated = await truncate_float(take_profit_price, 4)
-                stop_loss_truncated = await truncate_float(stop_loss_price, 4)
-
+                    if ress:
+                        take_profit_truncated = await truncate_float(take_profit_price, 6)
                         text += (f"Движение: {side_rus}\n"
                                  f"Тейк-профит: {take_profit_truncated}\n"
-                         f"Стоп-лосс: {stop_loss_truncated}\n"
                                  )
+                        if stop_loss_price is not None:
+                            stop_loss_truncated = await truncate_float(stop_loss_price, 6)
                         else:
+                            stop_loss_truncated = None
+
+                        if stop_loss_truncated is not None:
+                            text += f"Стоп-лосс: {stop_loss_truncated}\n"
+                        else:
+                            deals = await get_active_positions_by_symbol(
+                                tg_id=tg_id, symbol=symbol
+                            )
+                            position = next((d for d in deals if d.get("symbol") == symbol), None)
+
+                            if position:
+                                liq_price = position.get("liqPrice", 0)
+                                text += f"Цена ликвидации: {liq_price}\n"
+
+
+                    else:
+                        text += (f"Движение: {side_rus}\n"
+                                 "Не удалось установить ТП и СЛ\n")
+
+                else:
+                    if auto_trading:
                         new_pnl = safe_float(pnl_series) + total_pnl
                         await rq.set_pnl_series_by_symbol(
                             tg_id=tg_id, symbol=symbol, pnl_series=new_pnl)
-                text += f"\nДоход: {ex_pnl:.4f}\n"
-                text += f"Реализованный PNL: {total_pnl:.4f}\n"
+                        text += f"\nПрибыль без комиссии: {ex_pnl:.4f}\n"
+                        text += f"Реализованная прибыль: {total_pnl:.4f}\n"
                         text += f"Прибыль серии: {safe_float(new_pnl):.4f}\n"
+                    else:
+                        text += f"\nПрибыль без комиссии: {ex_pnl:.4f}\n"
+                        text += f"Реализованная прибыль: {total_pnl:.4f}\n"
 
                 await self.telegram_bot.send_message(
                     chat_id=tg_id, text=text, reply_markup=kbi.profile_bybit
@@ -240,6 +277,7 @@ class TelegramMessageHandler:
                                 "ab not enough for new order": "❗️ Недостаточно средств для продолжения торговли",
                                 "InvalidRequestError": "❗️ Недостаточно средств для размещения нового ордера с заданным количеством и плечом.",
                                 "The number of contracts exceeds maximum limit allowed": "❗️ Превышен максимальный лимит ставки",
+                                "Order placement failed as your position may exceed the max": "❗️ Превышен максимальный лимит ставки",
                             }
                             error_text = errors.get(
                                 res, "❗️ Не удалось открыть новую сделку"
@@ -283,6 +321,7 @@ class TelegramMessageHandler:
                                 "ab not enough for new order": "❗️ Недостаточно средств для продолжения торговли",
                                 "InvalidRequestError": "❗️ Недостаточно средств для размещения нового ордера с заданным количеством и плечом.",
                                 "The number of contracts exceeds maximum limit allowed": "❗️ Превышен максимальный лимит ставки",
+                                "Order placement failed as your position may exceed the max": "❗️ Превышен максимальный лимит ставки",
                             }
                             error_text = errors.get(
                                 res, "❗️ Не удалось открыть новую сделку"
@@ -302,6 +341,5 @@ class TelegramMessageHandler:
                                 text=error_text,
                                 reply_markup=kbi.profile_bybit,
                             )
-
         except Exception as e:
             logger.error("Error in telegram_message_handler: %s", e, exc_info=True)

app/bybit/web_socket.py

@@ -25,7 +25,6 @@ class WebSocketBot:
         self.user_keys = {}
         self.loop = None
         self.message_handler = TelegramMessageHandler(telegram_bot)
-        self.last_execution_seq = {}
 
     async def run_user_check_loop(self):
         """Run a loop to check for users and connect them to the WebSocket."""
@@ -106,17 +105,7 @@ class WebSocketBot:
         await self.message_handler.format_order_update(message, tg_id)
 
     async def handle_execution_update(self, message, tg_id):
-        """Handle execution updates."""
-        data_items = message.get('data', [])
-        if not data_items:
-            return
-        for exec_data in data_items:
-            seq = exec_data.get('seq')
-            if tg_id not in self.last_execution_seq:
-                self.last_execution_seq[tg_id] = -1
-            if seq <= self.last_execution_seq[tg_id]:
-                continue
-            self.last_execution_seq[tg_id] = seq
+        """Handle execution updates without duplicate processing."""
         await self.message_handler.format_execution_update(message, tg_id)
 
     @staticmethod

app/telegram/handlers/start_trading.py

@@ -97,7 +97,8 @@ async def start_trading(callback_query: CallbackQuery, state: FSMContext) -> Non
                 "Limit price is out min price": "Цена лимитного ордера меньше допустимого",
                 "Limit price is out max price": "Цена лимитного ордера больше допустимого",
                 "Risk is too high for this trade": "Риск сделки превышает допустимый убыток",
-                "estimated will trigger liq": "Лимитный ордер может вызвать мгновенную ликвидацию. Проверьте параметры ордера.",
+                "estimated will trigger liq": "Лимитный ордер может вызвать мгновенную ликвидацию. "
+                                              "Проверьте параметры ордера.",
                 "ab not enough for new order": "Недостаточно средств для создания нового ордера",
                 "InvalidRequestError": "Произошла ошибка при запуске торговли.",
                 "Order does not meet minimum order value": "Сумма ставки меньше допустимого для запуска торговли. "
@@ -106,6 +107,9 @@ async def start_trading(callback_query: CallbackQuery, state: FSMContext) -> Non
                 "Qty invalid": "Некорректное значение ставки для данного инструмента",
                 "The number of contracts exceeds maximum limit allowed": "️️Превышен максимальный лимит ставки",
                 "The number of contracts exceeds minimum limit allowed": "️️Лимит ставки меньше минимально допустимого",
+                "Order placement failed as your position may exceed the max":
+                    "Не удалось разместить ордер, так как ваша позиция может превышать максимальный лимит."
+                    "Пожалуйста, уменьшите кредитное плечо, чтобы увеличить максимальное значение"
             }
 
             if res == "OK":